Open
Conversation
dciborow
commented
Mar 12, 2023
Comment on lines
+5
to
+18
| && python -m pip install 'flit>=3.8.0' | ||
|
|
||
| ENV FLIT_ROOT_INSTALL=1 | ||
|
|
||
| COPY pyproject.toml README.rst ./ | ||
| RUN mkdir -p flit \ | ||
| && python -m flit install --only-deps --deps develop \ | ||
| && rm -r pyproject.toml README.rst flit | ||
|
|
||
| // ENV FLIT_ALLOW_INVALID=1 | ||
|
|
||
| // COPY pyproject.toml . | ||
| // RUN python -m flit install --only-deps --deps develop \ | ||
| // && rm -r pyproject.toml |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| && python -m pip install 'flit>=3.8.0' | |
| ENV FLIT_ROOT_INSTALL=1 | |
| COPY pyproject.toml README.rst ./ | |
| RUN mkdir -p flit \ | |
| && python -m flit install --only-deps --deps develop \ | |
| && rm -r pyproject.toml README.rst flit | |
| // ENV FLIT_ALLOW_INVALID=1 | |
| // COPY pyproject.toml . | |
| // RUN python -m flit install --only-deps --deps develop \ | |
| // && rm -r pyproject.toml | |
| && python -m pip install 'flit>=3.8.1' | |
| ENV FLIT_ROOT_INSTALL=1 | |
| ENV FLIT_ALLOW_INVALID=1 | |
| COPY pyproject.toml . | |
| RUN python -m flit install --only-deps --deps develop \ | |
| && rm -r pyproject.toml |
Contributor
Author
There was a problem hiding this comment.
after this PR is completed, we can update the docker file.
#631
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a devcontainer configuration which can be used with GitHub Codespace or with VSCode to create a local container.
The configuration includes the basics configurations for Python.